Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional entropy to client-side generation of storage_key in arbitrary secrets #141

Open
indomitableSwan opened this issue Oct 24, 2022 · 1 comment

Comments

@indomitableSwan
Copy link
Contributor

Currently the client generates storage_key used for e2e encrypted storage of data using just their internal RNG.

Instead:

  • the server should choose a nonce and send this to the client
  • the client should use their RNG to pick a seed uniformly at random, and then use a KDF to derive storage_key from the server-chosen nonce and the client-chosen seed.
@indomitableSwan
Copy link
Contributor Author

Recommendation: adjust naming of storage_key to emphasize that this is a key chosen client-side, e.g., client_storage_key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant