Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements on keys for bulk visitation are overly restrictive #263

Open
joaquintides opened this issue Jul 13, 2024 · 0 comments
Open

Comments

@joaquintides
Copy link
Member

Currently, bulk visitation requires that

[f]or K = std::iterator_traits::value_type, either K [be] key_type or else Hash::is_transparent and Pred::is_transparent [be] valid member typedefs.

This precludes the scenario where the keys are implicitly convertible to key_type, which seems to be overly restrictive. The drawback of allowing this is that conversion from std::iterator_traits<FwdIterator>::value_type to key_type will happen more than once for each key (twice, to be precise).

@joaquintides joaquintides changed the title Requirements on keys for bulk visitation are overly restrictive. Requirements on keys for bulk visitation are overly restrictive Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant