Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borg repair: deal with corrupt hints file #843

Closed
ThomasWaldmann opened this issue Apr 5, 2016 · 2 comments
Closed

borg repair: deal with corrupt hints file #843

ThomasWaldmann opened this issue Apr 5, 2016 · 2 comments
Assignees

Comments

@ThomasWaldmann
Copy link
Member

see: jborg/attic#375

todo:

  • reproduce (do we get same traceback still?)
  • can borg repair fix that?
@ThomasWaldmann ThomasWaldmann added this to the 1.1 - near future goals milestone Apr 5, 2016
@enkore
Copy link
Contributor

enkore commented Apr 6, 2016

The segment index / hints files are automatically regenerated (no check needed) if missing. So, just wrap the reading part in a try..except, log & delete & regenerate them?

Since that does require a lot of IO (skimming all segment files), and normally shouldn't happen => log level warning.

EDIT:

  • Corrupted index; borg.hashindex will raise "Exception('hashindex_read failed')"; Too broad to catch sanely, better narrow that. RuntimeError or lower
  • Something wrong with the hints file; raises msgpack.exceptions.XXX, but only if that file is actually used (Repository transaction created)

[x] Reproduced, changing tag question -> enhancement.

WIP

@enkore enkore self-assigned this Apr 8, 2016
@enkore
Copy link
Contributor

enkore commented May 30, 2016

Fixed in #858, further protections discussed in #1101

@enkore enkore closed this as completed May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants