Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey rectangular appears when moving connection segments #2002

Closed
barmac opened this issue Nov 2, 2023 · 9 comments
Closed

Grey rectangular appears when moving connection segments #2002

barmac opened this issue Nov 2, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@barmac
Copy link
Member

barmac commented Nov 2, 2023

Describe the Bug

A grey rectangular appears when moving connection segments:

Screen.Recording.2023-11-02.at.14.46.55.mov

Steps to Reproduce

  1. Create a connection
  2. Move segment

Expected Behavior

There should be no funny rectangular when dragging.

Environment

  • Browser: [e.g. IE 11, Chrome 69]
  • OS: [e.g. Windows 7]
  • Library version: v15.0.0
@barmac barmac added bug Something isn't working ready Ready to be worked on labels Nov 2, 2023
@barmac
Copy link
Member Author

barmac commented Nov 2, 2023

I discovered this while reviewing bpmn-io/dmn-js#800, so it may be either in diagram-js or copied over from bpmn-js to the dmn-js PR.

@smbea
Copy link
Contributor

smbea commented Nov 2, 2023

The removal of the selection line in connections is intentional. The funny rectangular thing is not though

@smbea
Copy link
Contributor

smbea commented Nov 2, 2023

See user stories here: "When selecting a sequence flow, I don't expect any selection outline at all."

@barmac
Copy link
Member Author

barmac commented Nov 2, 2023

Thanks for clarification. Then, we only need to fix the rectangular thing.

@barmac
Copy link
Member Author

barmac commented Nov 2, 2023

I will reword the issue to talk about the rectangular only.

@barmac barmac changed the title Selection outline for connections is gone Grey rectangular appears when moving connection segments Nov 2, 2023
@smbea
Copy link
Contributor

smbea commented Nov 2, 2023

Ok so this is actually unrelated to the selection changes. It comes from this commit, which related to the preview feature. If I comment that out, it works.

I don't exactly know what this is affecting. @philippfromme how can i safely fix this without breaking something else? 😅

@philippfromme
Copy link
Contributor

I will look into this.

@philippfromme philippfromme self-assigned this Nov 3, 2023
@philippfromme philippfromme added in progress Currently worked on and removed ready Ready to be worked on labels Nov 3, 2023
@philippfromme
Copy link
Contributor

Same issue when moving bendpoints. Seems affect all other components using djs-dragging.

image

philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Nov 3, 2023
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Nov 3, 2023
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Nov 3, 2023
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Nov 6, 2023
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Nov 6, 2023
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Nov 6, 2023
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Nov 6, 2023
@philippfromme
Copy link
Contributor

Fixed by #2016.

@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants