From 56a2ca08fabdebeda0c4d942d03e2f0232f5869d Mon Sep 17 00:00:00 2001 From: Philipp Fromme Date: Mon, 23 Sep 2024 14:27:01 +0200 Subject: [PATCH] chore(seach-pad): reduce padding --- lib/features/search-pad/SearchPad.js | 8 ++++++-- test/spec/features/search-pad/SearchPadSpec.js | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/features/search-pad/SearchPad.js b/lib/features/search-pad/SearchPad.js index 28c2aa8c6..4e1cefd17 100644 --- a/lib/features/search-pad/SearchPad.js +++ b/lib/features/search-pad/SearchPad.js @@ -26,6 +26,8 @@ import { isKey } from '../keyboard/KeyboardUtil'; * @typedef {import('./SearchPadProvider').Token} Token */ +var SCROLL_TO_ELEMENT_PADDING = 300; + /** * Provides searching infrastructure. * @@ -446,7 +448,7 @@ SearchPad.prototype._preselect = function(node) { domClasses(node).add(SearchPad.RESULT_SELECTED_CLASS); this._canvas.scrollToElement(element, { - top: 300 + top: SCROLL_TO_ELEMENT_PADDING }); this._selection.select(element); @@ -471,7 +473,9 @@ SearchPad.prototype._select = function(node) { this.close(false); - this._canvas.scrollToElement(element, { top: 400 }); + this._canvas.scrollToElement(element, { + top: SCROLL_TO_ELEMENT_PADDING + }); this._selection.select(element); diff --git a/test/spec/features/search-pad/SearchPadSpec.js b/test/spec/features/search-pad/SearchPadSpec.js index c54fa9b93..c20241cd2 100644 --- a/test/spec/features/search-pad/SearchPadSpec.js +++ b/test/spec/features/search-pad/SearchPadSpec.js @@ -438,7 +438,7 @@ describe('features/searchPad', function() { // then var newViewbox = canvas.viewbox(); expect(newViewbox).to.have.property('x', -100); - expect(newViewbox).to.have.property('y', -400); + expect(newViewbox).to.have.property('y', -300); }));