Please do not add external links to author in model.json

[Mariusthvdb]

Having acquired a 1745630P7 Hue light I installed it in Powercalc today.

This came with a surprise, and a request.

Given the model.json holds an author field I never noticed before, I checked many of my other models, and none of those have a filed in the model pointing to an external source.

Tbh, I would prefer if it remained that way, and was wondering what the 'official' take of the Powercal code owner is on the matter
I always like to keep external links to an absolute minimum, and add only on 'essential for functionality' base.
Given these are now added to our system automatically, Id like to raise the issue here as a Question (it isnt an issue (yet))

 {
  "calculation_strategy": "lut",
  "measure_description": "Measured with utils/measure script",
  "measure_device": "Shelly Plug S",
  "measure_method": "script",
  "measure_settings": {
    "SAMPLE_COUNT": 2,
    "SLEEP_TIME": 3,
    "VERSION": "v1.9.6:docker"
  },
  "name": "1745630P7",
  "standby_power": 0.27,
  "device_type": "light",
  "created_at": "2023-11-21T13:39:09",
  "author": "Imperial-Guard <[email protected]>"
}

Secondly, I suppose the light fixture at hand should be named the Hue Outdoor Wall in stead of 1745630P7, and even model name Nyro could be added, next to the numbered code

Ill gladly PR those fields, upon response from Bram

[bramstroker]

I have added author field some time ago to give credits to contributors.
The information is extracted from the commit information of github, which is public information.
<[email protected]> is also from github commit, I might strip that information between < and >, but no big deal it's there imo.

About 1745630P7, you are correct. That should be the marketed name, and would be nice to also have Nyro there, as other lights also have the marketed name.
Would be nice if you can make a PR of that.

Also look at the other Signify lights at:
https://library.powercalc.nl/

[Mariusthvdb]

consider that done: #2539

[bramstroker]

thx