Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a cookie exception list #5314

Closed
ryanbr opened this issue Jul 22, 2019 · 12 comments
Closed

Create a cookie exception list #5314

ryanbr opened this issue Jul 22, 2019 · 12 comments
Labels
closed/invalid feature/cookie-allow-list feature/shields/cookies Cookie controls implemented as part of Shields. feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon". privacy privacy-pod Feature work for the Privacy & Web Compatibility pod

Comments

@ryanbr
Copy link

ryanbr commented Jul 22, 2019

Need to create/implement a cookie whitelist, for problematic sites where if we block 3rd-party cookies it causes issues.

Was reported here with udemy.com; #4496

Create a .json of any problematic sites where blocking 3rd party sites can be added, avoiding the need for notifying customers they need to allow all cookes for these specific sites. Similar to the https://github.com/brave/referrer-whitelist but for cookies.

(possibly create 3rd-party device recog list also?).

@ryanbr
Copy link
Author

ryanbr commented Jul 22, 2019

Example of a simple fix for udemy.com;

    {
        "https://www.udemy.com/": [
            "https://*.udemycdn-a.com/*"
        ]
    }

@ryanbr
Copy link
Author

ryanbr commented Jul 22, 2019

Could fix this issue also; #5289

@rebron rebron added the feature/shields/cookies Cookie controls implemented as part of Shields. label Jul 26, 2019
@rebron rebron added feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 9, 2019
@fmarier
Copy link
Member

fmarier commented Oct 15, 2019

Looking at the more general problem, it would be nice if we had something like the Mozilla entity list (a lot smaller though) to group related domains together for the purpose of determining third-party'ness in cookie and referrer blocking.

That way, we could just treat udemy.com and udemycdn-a.com as the same thing in both places with a single exception.

@tildelowengrimm
Copy link
Contributor

I just want to confirm that the aim here is to enumerate (small) sets of registerable domains which should be treated as the same for cookie (and perhaps other privacy/storage/shields?) purposes? The title sounds like a global allow-list of sites which should be able to set cookies wherever, but that's not the case, correct?

@pes10k
Copy link
Contributor

pes10k commented Feb 13, 2020

There may be two similar-but-different goals here. The main goal is another tool for fine-grain-web-compat fixing, a way to unbreak a site w/o allowing "everything"

The other goal could be to do something like origin sets / disconnect entity-list.

I don't think anyone is suggesting a allow-list of sites which should be able to set cookies :)

@tildelowengrimm
Copy link
Contributor

I think this feature is complex enough that someone needs to specify out the details of what this specific issue is for. If needed, we can add another issue for the other thing (which should also be specified in detail).

@pes10k
Copy link
Contributor

pes10k commented Feb 13, 2020

Okie, just to make sure we're all on the same page, the goal is to have something like the exception rules defined here https://github.com/brave/brave-core/blob/134798d731d3f0a5ee7e3b471c2f4ab843383a59/common/shield_exceptions.cc

But 1) for cookies, and 2) some place easier to change than C++.

If that sounds possibly-useful on your end, i'll update the issue desc now

@tildelowengrimm
Copy link
Contributor

The only things which I think should potentially be updated out-of-sequence in that file are the sites which get a different UA, and that's being resolved elsewhere. Is there a good example of where it makes sense to ignore the Shields cookie setting?

@tildelowengrimm tildelowengrimm added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Feb 19, 2020
@tildelowengrimm
Copy link
Contributor

The ephemeral third-party storage work should fix most of this.

@tildelowengrimm tildelowengrimm added the privacy-pod Feature work for the Privacy & Web Compatibility pod label Feb 19, 2020
@pes10k pes10k changed the title Create a cookie whitelist json Create a cookie exception list Mar 12, 2020
@antonok-edm
Copy link
Collaborator

Breakage on Microsoft Teams (#6046) could also be fixed with this.

@pes10k
Copy link
Contributor

pes10k commented Jul 23, 2020

Closing this since it will not be needed post #8514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid feature/cookie-allow-list feature/shields/cookies Cookie controls implemented as part of Shields. feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon". privacy privacy-pod Feature work for the Privacy & Web Compatibility pod
Projects
None yet
Development

No branches or pull requests

7 participants