Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual specifier should not be present if override or final are #924

Open
cjdb opened this issue May 22, 2023 · 0 comments
Open

virtual specifier should not be present if override or final are #924

cjdb opened this issue May 22, 2023 · 0 comments
Labels
suggestion Possible enhancement, open for debate

Comments

@cjdb
Copy link

cjdb commented May 22, 2023

A C++ best practice is to provide exactly one of virtual, override, or final. This is recommended by both the C++ Core Guidelines and the Google C++ Style Guide.

Documentation tooling should follow suit so as to not encourage dangerous antipatterns.

@vermeeren vermeeren added enhancement Improvements, additions (also cosmetics) suggestion Possible enhancement, open for debate and removed enhancement Improvements, additions (also cosmetics) labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Possible enhancement, open for debate
Projects
None yet
Development

No branches or pull requests

2 participants