Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate between PaymentListItem and Payment #563

Open
JssDWt opened this issue Oct 27, 2023 · 0 comments · May be fixed by #761
Open

Seperate between PaymentListItem and Payment #563

JssDWt opened this issue Oct 27, 2023 · 0 comments · May be fixed by #761
Labels
good first issue Good for newcomers

Comments

@JssDWt
Copy link
Contributor

JssDWt commented Oct 27, 2023

send_payment and send_spontaneous_payment use the same return type Payment as list_payments. They mean very different things, however. list_payments is meant to give you a list of all the balance mutations: receives, sends, closed channels.

Suggestion is to rename the current Payment to PaymentListItem. It will be returned by list_payments.
And use a different model that is more suited for the send_payment and send_spontaneous_payment functions.

@JssDWt JssDWt added the good first issue Good for newcomers label Oct 27, 2023
@ubbabeck ubbabeck self-assigned this Nov 7, 2023
@roeierez roeierez added this to the v0.3.0-alpha (Notifications) milestone Jan 2, 2024
@hydra-yse hydra-yse linked a pull request Jan 27, 2024 that will close this issue
@ubbabeck ubbabeck removed their assignment Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
3 participants