Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No autocomplete on restore seed, autocomplete #505

Open
ok300 opened this issue Feb 22, 2023 · 4 comments
Open

No autocomplete on restore seed, autocomplete #505

ok300 opened this issue Feb 22, 2023 · 4 comments
Assignees
@erdemyerebasmaz
Labels
enhancement New feature or request good first issue Good for newcomers low priority

Comments

@ok300
Copy link
Collaborator

ok300 commented Feb 22, 2023

The BIP39 words are uniquely identified by the first four letters.

We can use this to simplify the UX on the Restore Seed screen: after first four letters typed in, Breez could auto-complete the word and already move the UI focus on the next input field
@erdemyerebasmaz erdemyerebasmaz added enhancement New feature or request good first issue Good for newcomers labels Feb 22, 2023
@kingonly
Copy link
Member

We have auto complete in Breez Mobile. This a bug, not a feature...

@kingonly kingonly changed the title Feature: On restore seed, autocomplete word and go to next after first 4 chars entered No autocomplete on restore seed, autocomplete Feb 22, 2023
@kingonly
Copy link
Member

Please use the same autocomplete logic of Breez Mobile

@erdemyerebasmaz
Copy link
Collaborator

erdemyerebasmaz commented Feb 22, 2023 •
edited
Loading

We have auto complete in Breez Mobile. This a bug, not a feature...
Please use the same autocomplete logic of Breez Mobile

What he means is completing the word after typing four letters(as BIP39 words are uniquely identified by the first four letters) without the need to click on the word of autocomplete result.

For example:
> qua

quality
quantum
quarter

typing the fourth letter should fill the field with the matching value then focus on the next input field.

@kingonly
Copy link
Member

Gotcha. This is nice to have, but let's prioritize the alpha release first.

@erdemyerebasmaz erdemyerebasmaz self-assigned this Jul 3, 2023
@roeierez roeierez added this to the v0.1.1-alpha milestone Jul 13, 2023
erdemyerebasmaz added a commit that referenced this issue Jul 17, 2023
@erdemyerebasmaz
Autocomplete on restore form
0d2c93e 
closes #505
@erdemyerebasmaz erdemyerebasmaz mentioned this issue Jul 17, 2023
Closed
@erdemyerebasmaz erdemyerebasmaz linked a pull request Jul 17, 2023 that will close this issue
Autocomplete on restore form #606
Closed
erdemyerebasmaz added a commit that referenced this issue Sep 25, 2023
@erdemyerebasmaz
Autocomplete on restore form
51ef0f8 
closes #505
erdemyerebasmaz added a commit that referenced this issue Oct 4, 2023
@erdemyerebasmaz
Autocomplete on restore form
5b180a0 
closes #505
@erdemyerebasmaz erdemyerebasmaz removed this from the v0.2.4 alpha(sdk) milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erdemyerebasmaz erdemyerebasmaz

Labels
enhancement New feature or request good first issue Good for newcomers low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Autocomplete on restore form breez/c-breez
4 participants
@erdemyerebasmaz @roeierez @kingonly @ok300