Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeplinking or scanning an invoice from your own node does 'nothing' #613

Open
JssDWt opened this issue Jul 31, 2023 · 2 comments
Open

Deeplinking or scanning an invoice from your own node does 'nothing' #613

JssDWt opened this issue Jul 31, 2023 · 2 comments

Comments

@JssDWt
Copy link
Contributor

JssDWt commented Jul 31, 2023

If you scan an invoice from your own node, or deeplink an invoice from your own node, the app does nothing.

Expected:
When you scan an invoice that's from your own node, display an error like "self payments not allowed"

Screen_Recording_20230731_150926_Phoenix.mp4
@roeierez roeierez added this to the v0.1.1-alpha milestone Sep 13, 2023
@ubbabeck ubbabeck self-assigned this Sep 18, 2023
@ubbabeck
Copy link
Contributor

This is the same behaviour as in Breezmobile which is the reference for C-breez. If a user pastes or scans invoices from the same nodeID nothing happens.

@kingonly just to be sure, do we wish to add error handling (eg. showing a flushbar) for payment attempts to the same node?

@kingonly
Copy link
Member

We can. Nice to have, but not a priority.

@ubbabeck ubbabeck removed this from the v0.1.1-alpha milestone Oct 5, 2023
@ubbabeck ubbabeck removed their assignment Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants