Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support for more fiat currencies than cryptocompare.com offers #1

Open
jemilsson opened this issue Jun 26, 2019 · 4 comments

Comments

@jemilsson
Copy link

jemilsson commented Jun 26, 2019

May i suggest you add support for more currencies than cryptocompare.com offers? It would be really neat to have data for smaller currencies.

This could be achieved through converting the USD or EUR exchange rates indirectly. There are many services for obtaining rates between USD or EUR and other currencies, for example the ECB publishes reference rates for free.. The ECB data is also exposed in a more RESTful way here.

It would be preferable to have an even larger number of currency pairs, but from what i have found there is no free source of this data. Perhaps you could use something like Fixer.io?

@yaslama
Copy link
Member

yaslama commented Jun 27, 2019

Thanks a lot for the suggestion. I'll add to our TODO list. You are also welcome to open a PR.

@jemilsson
Copy link
Author

If i were to create a PR for this, would you prefer me to implement something free like the ECB reference rates or something with better coverage like the fixer.io service?

@yaslama
Copy link
Member

yaslama commented Jul 4, 2019

@jemilsson It's better to begin with ECB. If we want to use also services like Fixer.io, we need to add a mechanism to limit calls to each service.

@tmlee
Copy link

tmlee commented Jul 6, 2019

May i suggest considering the CoinGecko open public API?
You can query a wide range of currencies we support on the website https://www.coingecko.com/en/coins/bitcoin

API calls can be made as simple as https://api.coingecko.com/api/v3/simple/price?ids=bitcoin&vs_currencies=usd,eur,gbp,jpy,cad,chf,cny,hkd,idr,rub,twd and you can append more currencies if you would like to

The API is straight forward enough to call directly, but should you need a Go library, there is a 3rd party https://github.com/superoo7/go-gecko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants