Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code signing script needs update #109

Open
OskarGroth opened this issue Oct 22, 2019 · 2 comments
Open

Code signing script needs update #109

OskarGroth opened this issue Oct 22, 2019 · 2 comments

Comments

@OskarGroth
Copy link

OskarGroth commented Oct 22, 2019

Not using this software, but ran into the same problem and thought I'd drop a hint.

The CodeSigningUpdate (https://github.com/brightdigit/Speculid/blob/12ef69622a6940f75201f4767566a79345146ff2/scripts/CodeSignUpdate.sh) script is failing on Xcode 11 because Mac Developer certificates are now on the form Apple Development: instead of Mac Developer:.

You incorrectly fixed this by commenting out set 36ff4be#diff-de6b762ded769596e652fd6f22b5e3af which causes the script to finish despite the errors, but the error still occur and as a result your Info.plist is borked:

<string>identifier "com.brightdigit.Speculid-Mac-Installer" and anchor apple generic and Invalid Mac Developer CN: Apple Development: Leo Dion (5VZ4KT69B9) and certificate 1[field.1.2.840.113635.100.6.2.1] /* exists */</string>

Instead, the error can be fixed correctly by updating the scripts macDeveloper function as follows:

if ! [[ ${macDeveloperCN} =~ ^Apple\ Development:\ .*\ \([A-Z0-9]{10}\)$ ]]; then
    printf "%s\n" "Invalid Mac Developer CN: ${macDeveloperCN}"
    exit 1
fi
@leogdion leogdion added this to the v2.0.0-beta.1 milestone Oct 22, 2019
@leogdion
Copy link
Member

Thanks @OskarGroth I'll look into this.

leogdion added a commit that referenced this issue Jan 22, 2020
@leogdion
Copy link
Member

@OskarGroth I am still having issues with this even after changing the script. Not sure if it's still the same issue. https://travis-ci.org/brightdigit/Speculid/builds/640931671

@leogdion leogdion removed this from the v2.0.0-beta.1 milestone Apr 13, 2020
leogdion added a commit that referenced this issue Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants