Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

+ side button doesn't go to the new line when insert embed video #119

Open
Andresmag opened this issue Feb 12, 2018 · 4 comments
Open

+ side button doesn't go to the new line when insert embed video #119

Andresmag opened this issue Feb 12, 2018 · 4 comments

Comments

@Andresmag
Copy link

captura de pantalla 2018-02-12 a las 16 49 30

So as you can see in the image above, the + button remains at the top of the video when you insert it instead of going down to the new line where it should be. This image is taken from the demo example in the repository so I suppose this is a bug to fix.

Do you have any idea about how to solve it? Or are you already working on it?

Congratulations for the great job you're doing! :)

@brijeshb42
Copy link
Owner

This is a known issue. This occurs because as the embed loads, it's height change is not noticed by the button and it remains at its position. If you press enter again the button will change position correctly. Will have to have a workaround to fix this issue.

@Andresmag
Copy link
Author

Ok, perfect. But I've just noticed that the demo do something strange in Chrome, when you click the + button, the view goes to the top of the page losing where it was. Did you know anything about it?

@d-baranowski
Copy link

+1
Is there any way I can prod the button to update programmatically? I receive the an event once the video is fully loaded so I could just launch a callback which could trigger the button position update. Is there anything in place that could let me do that?

@brijeshb42
Copy link
Owner

@d-baranowski You can call foreUpdate method of your component to rerender.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants