You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many TensorMaps make use of the shape inference from the channel_map in the TensorMap constructor. I agree we should fail early if that inference fails, but I don't think we need to make shape required.
What
Make
shape
required forTensorMap
and check the other parameters if they should be required.Why
You should get an error making a
TensorMap
without a shape, because it can't be used in a model. Fail early!How
Remove the default of
None
forshape
. See if the recipes still run using the smoke tests if other defaults are removed.Acceptance Criteria
Less
Optional
parameters.The text was updated successfully, but these errors were encountered: