Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keysForTree is currently deopting. #9

Open
stefanpenner opened this issue May 13, 2014 · 2 comments · May be fixed by #13
Open

keysForTree is currently deopting. #9

stefanpenner opened this issue May 13, 2014 · 2 comments · May be fixed by #13

Comments

@stefanpenner
Copy link
Contributor

https://github.com/broccolijs/broccoli-kitchen-sink-helpers/blob/master/index.js#L31-L41
https://github.com/broccolijs/broccoli-kitchen-sink-helpers/blob/master/index.js#L55-L62

these try/catches needs to be isolated from the rest of the function. This is easiest accomplished by extracting those blocks behaviors into there own functions.

Should be a quick fix
@luto
Copy link

luto commented May 13, 2014

grabbing this.

@stefanpenner
Copy link
Contributor Author

@luto 👍

luto added a commit to luto/broccoli-kitchen-sink-helpers that referenced this issue May 13, 2014
@luto
move try/catch out of keysForTree(), fix broccolijs#9
1807df9
luto added a commit to luto/broccoli-kitchen-sink-helpers that referenced this issue May 13, 2014
@luto
move try/catch out of keysForTree(), fix broccolijs#9
c1b2e7d
@luto luto linked a pull request May 13, 2014 that will close this issue
Open
luto added a commit to luto/broccoli-kitchen-sink-helpers that referenced this issue May 13, 2014
@luto
move try/catch out of keysForTree(), fix broccolijs#9
2d55093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move try/catch out of keysForTree(), fix #9 luto/broccoli-kitchen-sink-helpers
2 participants
@stefanpenner @luto