Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build --overwrite error #15

Open
Lazerbeak12345 opened this issue Sep 19, 2019 · 0 comments
Open

build --overwrite error #15

Lazerbeak12345 opened this issue Sep 19, 2019 · 0 comments

Comments

@Lazerbeak12345
Copy link

The problem

I've been following the guide on the getting started page and I noticed an error.
(I'm sorry if this isn't the correct repo, but it seems like it would be the right place)

The page says the following:

To run a build, run yarn build (if you added the script) or broccoli build --overwrite (note: without --overwrite the contents of the output directory dist will NOT be overwritten and produce an error).

I tried running npx broccoli build --overwrite yarn broccoli build --overwrite and yarn build --overwrite yet they all have approximately this output:

yarn run v1.17.3
warning package.json: No license field
$ broccoli build --overwrite
error: unknown option `--overwrite'
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

My hunch is that this command was deprecated, and the guide hasn't been updated yet.

Solutions

Here's a list of different independent possible solutions.

  • Update the website to reflect above-mentioned depreciation/removal
  • Add the feature back to the code
  • Repair the bug

My personal opinion is that the argument should be ignored, for compatibility, and should be removed from the doc.
(My reason the tsc compilation command automatically replaces any file effected by the source change. I really like this approach.)

Note: I had previously opened the issue on this repository,
but I did a bit more digging, and this may be the one to propose the issue too.

I'll close the issue on the other one for now, at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant