Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

How would I "pop-out" a tab from the tab group? #141

Closed
joshuakoh1 opened this issue Mar 7, 2022 · 5 comments
Closed

How would I "pop-out" a tab from the tab group? #141

joshuakoh1 opened this issue Mar 7, 2022 · 5 comments

Comments

@joshuakoh1
Copy link

If I would like to run the tab in a different window while preserving the state how would I do it?

@brrd
Copy link
Owner

brrd commented Mar 7, 2022

This is a duplicate: #75

@brrd brrd closed this as completed Mar 7, 2022
@brrd brrd added the duplicate label Mar 7, 2022
@joshuakoh1
Copy link
Author

Hi @brrd, I wouldn't call it a duplicate.

The original question was whether there was an existing feature for it but I'm asking to be pointed in the direction on how to put together something since the feature doesn't exist at the moment.

Is there a way to transfer the state into a different window outside of this library or does it have to be "popped out" from within this library?

@brrd
Copy link
Owner

brrd commented Mar 8, 2022

I think both questions should be answered in the same thread. When we will add this feature to electron-tabs (if this is possible) we will probably be interested in the workaround you found.

I don't think there is an easy way to do this currently. Obviously Electron allows you to move a webview to a different web content: electron/electron#1871
You will have to deal with all the rest: opening the new window, creating a new instance TabGroup, opening a new tab, moving the webview to it and deleting the initial tab.

@joshuakoh1
Copy link
Author

@brrd Is it possible to add buttons before the X button for each tab? If the add tab API accepts a list of Buttons with {icon, function} then it would be able to implement a pop out functionality.

There would also need to be a way to pass the webview guest id from the original tab into the called function but this seems tricky because the guest id is only available after the tab is created.

@brrd
Copy link
Owner

brrd commented Apr 11, 2022

This issue is closed because it is a duplicate. Please use #75 instead.

Repository owner locked and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants