Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops listening to combo after exception in handler #102

Open
ntnkrsh opened this issue Mar 1, 2019 · 1 comment
Open

Stops listening to combo after exception in handler #102

ntnkrsh opened this issue Mar 1, 2019 · 1 comment
Labels

Comments

@ntnkrsh
Copy link

ntnkrsh commented Mar 1, 2019

Hello! I've got a problem, if you register handler for some combination and you got an exception in that handler - next time that combo wouldn't fire the handler.
For example here is my code:

this.hotkeyService.add(new Hotkey('ctrl+shift+e', (event: KeyboardEvent, combo: string): boolean => { throw new Error('error!'); return false; }));

as I've already said - the first time we successfully get into the callback, but next time nothing happens.

@wittlock wittlock added the bug label May 29, 2019
@wittlock
Copy link
Collaborator

This will take some investigation to figure out what's going on. Thanks for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants