Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom CSS should be for client use only, Super Admins/Designers in ID should have separate Stylesheet in admin #3

Open
acketon opened this issue Feb 10, 2016 · 0 comments
Assignees

Comments

@acketon
Copy link
Member

acketon commented Feb 10, 2016

For some clients ID writes a custom stylesheet to modify the default Responsive Framework theme. Currently we save this in Custom CSS for use on production. It works okay, however I believe it is the wrong architectural structure and has some issues for clients.

The stylesheets we write and include tend to be long. They can easily be over 1,000 lines and modify large areas of the site. We use a custom stylesheet to modify the core theme for sites that do not need a custom child theme. We consider it overkill to create a child theme just to modify a stylesheet.

Because they tend to be long and complicated compared to how clients use Custom CSS our styles dominate the Custom CSS editor and makes it harder for the client to easily add their own styles without risking breaking, deleting or modifying the styles that we have crafted for them to match a specific design for the site. If they add styles they should be scrolling to the bottom of the editor and adding their own styles at that position but there is not way to enforce that and they could easily delete or modify the core styles for their site design inadvertently while trying to add styles for something new or unique.

We should consider a structure for stylesheets that adds a new middle layer for the Designer & Super Admin role cascading in the following order

  1. Site Stylesheet(s) from Theme
  2. New Designer Customization Stylesheet in Admin
  3. Custom CSS

A site that is designed and built by ID via a custom stylesheet would load the following styles:

  1. Framework styles loaded by the theme
  2. This would be a new Custom CSS-like editor or a way to attach a stylesheet for Designer & Super Admin Roles
  3. The existing Custom CSS editor would be left empty in this case and reserved for use by the client in the future. In many cases the plugin might not even have to be turned on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants