Skip to content
This repository has been archived by the owner on Nov 15, 2018. It is now read-only.

Create performance impact tests/reports #4

Open
lance opened this issue Aug 23, 2016 · 5 comments
Open

Create performance impact tests/reports #4

lance opened this issue Aug 23, 2016 · 5 comments

Comments

@lance
Copy link
Member

lance commented Aug 23, 2016

Code tracing can be expensive. How expensive? Well, we don't know yet. We should produce reports with the build that show what the cost of enabling tracing is.

@helio-frota
Copy link
Member

I dunno if genet can help us, since genet does not accumulates calls :/

@helio-frota
Copy link
Member

  • I dunno if is correct to sum all genet lightbright related calls
  • If yes ^ maybe we can create a filter or something to separate only lightbright related calls, then we can see some impact.

[1ms]-------------[2ms]------------[1ms]-------------[1ms]
functionA() --> lightbright() --> functionB() --> lightbright()

lightbright() : 3ms

makes sense ?

@helio-frota helio-frota self-assigned this Oct 27, 2016
@helio-frota
Copy link
Member

@helio-frota
Copy link
Member

I think travis is not the 'correct' place to do a bench test
This is the 'more correct' results from lightbright:

hf@archT440 ~/p/lightbright/benchmark ±lightbright-4⚡ » node benchmark2.js
With lightbright x 99,825 ops/sec ±0.62% (92 runs sampled)
hf@archT440 ~/p/lightbright/benchmark ±lightbright-4⚡ » node benchmark3.js
Without lightbright x 102,732 ops/sec ±0.89% (86 runs sampled)
99k ops/sec with LB and 102k ops/sec without LB

Running without LB first on CI, will consume resources and causing this:
https://travis-ci.org/bucharest-gold/lightbright/jobs/172602367#L612
https://travis-ci.org/bucharest-gold/lightbright/jobs/172602367#L621

@helio-frota
Copy link
Member

@lance lance added the stalled label Apr 4, 2017
@helio-frota helio-frota removed their assignment Oct 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants