Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override v1Config() function #89

Open
josegonzalez opened this issue Jan 21, 2021 · 2 comments
Open

Add ability to override v1Config() function #89

josegonzalez opened this issue Jan 21, 2021 · 2 comments
Labels

Comments

@josegonzalez
Copy link

josegonzalez commented Jan 21, 2021

The default is great, but it would be nice to be able to override the v1Config() function (or potentially wrap it) to inject platform-specific values into the image config. I'm happy to make the relevant PR(s) if others think this is a good idea :)

@ekcasey
Copy link
Member

ekcasey commented Feb 4, 2021

Rather than overriding v1Config() I would rather we add more functionality to the imgutil.Image interface to expose whatever features are missing. What fields in config would you like to be able to set that are not currently exposed?

@josegonzalez
Copy link
Author

josegonzalez commented Feb 4, 2021

The main thing is I'd like to drop the history zero'ing that happens here and set a new time here.

I have this project that is basically used to add/remove image labels without requiring a docker build - which triggers ONBUILD directives... - but the zero'ing (which works great for CNB!) isn't ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants