Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildpack Registry Namespace Notifier #11

Open
aswintim opened this issue Mar 9, 2021 · 5 comments
Open

Buildpack Registry Namespace Notifier #11

aswintim opened this issue Mar 9, 2021 · 5 comments
Assignees

Comments

@aswintim
Copy link
Contributor

aswintim commented Mar 9, 2021

This would create an automated process that notifies the Distribution Team when Buildpack Registry namespace is created or updated.

For more information: https://docs.google.com/document/d/1Ygqzm9Z7wGvKQ2Bsj5UIczBotqQ8CPY8T3bWdqr9xqM/edit#

@aswintim
Copy link
Contributor Author

aswintim commented Mar 9, 2021

I am working on it. Please assign it to me. Thank you!

@aswintim
Copy link
Contributor Author

aswintim commented Mar 9, 2021

The specification mentions that the workflow triggers on every commit. I am a bit confused about it. Does that mean, it should trigger on every push to the main branch?

@jkutner
Copy link
Member

jkutner commented Mar 9, 2021

@AswinTimalsina Yea, every merge/push to main branch is correct. The wording in the doc is wrong.

@aswintim
Copy link
Contributor Author

aswintim commented Mar 9, 2021

Thanks @jkutner!

One more thing, it says, the automation should check if any new file is added and check if existing files were changed. Should it trigger on every deletion of file too? If it is the case then any changes on buildpacks/registry-namespaces should trigger the action. Isn't it?

@jkutner
Copy link
Member

jkutner commented Mar 9, 2021

@AswinTimalsina I don't think we need to worry about deletion (I'm not even sure we support deleting the namespaces).

You can probably split the create and update into two parts if it makes it easier. The most important notification is create, because that's the step that can happen without a person being involved (i.e. anyone can claim a new namespace)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants