Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArsTechnica links include a menu and a footer #22

Closed
matejdro opened this issue Nov 21, 2023 · 2 comments
Closed

ArsTechnica links include a menu and a footer #22

matejdro opened this issue Nov 21, 2023 · 2 comments

Comments

@matejdro
Copy link

matejdro commented Nov 21, 2023

A minor issue: When attempting to save ars technica article, for example

https://arstechnica.com/space/2023/11/heres-why-this-weekends-starship-launch-was-actually-a-huge-success/

resulting epub includes a menu at the top:

image

and a footer at the bottom:

image

Both of these are not there in Firefox's reader mode.

@bunglegrind
Copy link
Owner

Well, let me explain my typical use case, which acts as the foundation of my fork:
basically, when I'm converting a page, I wrote a custom css rule to get rid of all of the content I don't need (usually sidebars, menus, ads, annoying popups, accessibility menus like the one you indicated, etc.). and to stretch the main content to the 100% of the page. Firefox Style Editor and an ublock origin are the tools I employ.

For instance:

        {
            "style": "#navigation,\n#banner,\n#footer,\n.navigate,\n#commentform,\n.entry-footer\n{\n  display: none;\n  \n}\ndiv#content\n{\n  max-width: 100%;!important;\n  margin: 0!important;\n}\n\n.wp-block-image img\n{\n    max-width: 35em!important;\n}\n\nfigure {\n    margin: 0!important;\n}",
            "title": "Chip Morningstar",
            "url": "habitatchronicles\\.com"
        }

This is part of the json file my fork is able to import/export.

That said, to answer your question, it's out of scope selecting which page component must go into the epub, because, well, it's subjective.
However, there's an open issue about this #8 but probably, just using the advanced tools ublock origin already exposes it's enough.

@matejdro
Copy link
Author

Thanks for the answer, closing in favor of #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants