Pass card options to card/atom components #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylenathan
force-pushed
the
pass-options-to-cards-and-atoms
branch
from
a24ae6a
to
b451a22
Compare
|
Don't mind at all, @kylenathan — I apologize to the project maintainers for letting issue #82 languish for so long, and I'd still love to see the functionality get merged! |
mixonic
reviewed
Feb 9, 2017
| @@ -217,6 +220,7 @@ export default Component.extend({ | |||
| this.get('componentAtoms').removeObject(atom); | |||
| } | |||
| }; | |||
| editorOptions.cardOptions = assign(componentHooks, editorOptions.cardOptions); | |||
There was a problem hiding this comment.
@kylenathan we're not convinced that merging user cardOptions over the editor built-in hooks is best. Really the built-in hooks should not need to be stomped, and if they are stomped we will end up with a mess.
At some point we should make the ADD_CARD_HOOK constant into a symbol, since we don't want the property name to be guessable by the outside world, and don't want it to conflict either.
This can just be reversed though, and the componentHooks can win. I'm going to make that change and land this 🎉
|
Replaced by #125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
@decasia - Hope you dont mind, we needed this quite urgently so have pretty much copied your fork, added a fix and some tests.
Nudging @mixonic