Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rumqttc - AUTH packet support #840

Open
ting-ms opened this issue Apr 7, 2024 · 13 comments · May be fixed by #852
Open

rumqttc - AUTH packet support #840

ting-ms opened this issue Apr 7, 2024 · 13 comments · May be fixed by #852
Labels

Comments

@ting-ms
Copy link

ting-ms commented Apr 7, 2024

Are there any plans to support the AUTH packet for enhanced authentication? If such plans are in motion, we'd love to know when users can expect this feature to become available.

@swanandx
Copy link
Member

swanandx commented Apr 9, 2024

there aren't any active / ongoing plans for this, but would definitely want it!

we are open for contribution 😀

@ting-ms
Copy link
Author

ting-ms commented Apr 10, 2024

Thank you for your response. We would like to investigate the feature further and explore the possibility of contributing to its development.

@de-sh de-sh added the packets label Apr 10, 2024
@de-sh de-sh mentioned this issue Apr 10, 2024
2 tasks
@de-sh
Copy link
Contributor

de-sh commented Apr 10, 2024

Once #845 is merged, would love to see design suggestions for the interface with user. Hopefully with the implementation as well.

@ting-ms
Copy link
Author

ting-ms commented Apr 11, 2024

Hi @de-sh, it's great to see progress being made on Auth packet support. I'd love to contribute to the design and implementation of the user interface. While testing enhanced authentication with EMQX, I encountered issues passing authentication successfully. I'm curious if you have any recommended MQTT broker for testing enhanced authentication.

@de-sh
Copy link
Contributor

de-sh commented Apr 11, 2024

While testing enhanced authentication with EMQX, I encountered issues passing authentication successfully.

Can you elaborate on this? Would be helpful if we have code to debug this with.

I'm curious if you have any recommended MQTT broker for testing enhanced authentication.

No recommendations, I believe even rumqttd doesn't support the auth packet as of right now. Might be a good first issue for sometime @swanandx

@ting-ms
Copy link
Author

ting-ms commented Apr 12, 2024

I wrote some experimental code to connect with the EMQX broker using enhanced authentication. However, the broker responded with a ConAck indicating "Not Authorized." I have already filed an issue regarding this matter. Please review the details here: emqx/emqx#12860

@ting-ms
Copy link
Author

ting-ms commented Apr 25, 2024

Hi @swanandx @de-sh , I have created an initial version of the user interface design for enhanced authentication. You can find it in the attached document:
RumqttcEnhancedAuhtenticationInterfaceDesign.md

Aside from user interface design, I've also included some example code for enhanced authentication testing that I've implemented in my local branch.

Your feedback would be greatly appreciated.

@ting-ms ting-ms linked a pull request Apr 28, 2024 that will close this issue
2 tasks
@ting-ms
Copy link
Author

ting-ms commented Apr 28, 2024

Hi @swanandx @de-sh, I've created a draft pull request for the feature support. Please take a moment to review it when you have a chance. Your feedback is greatly appreciated!

@swanandx
Copy link
Member

thanks for the PR @ting-ms ! really appreciate the work.

but currently I don't have bandwidth for this, so might get delayed. thanks for understanding!

@ting-ms
Copy link
Author

ting-ms commented May 8, 2024

Hi @swanandx @de-sh , I hope you're doing well. Any updates on the PR review? If there's anything I can do about the PR, please let me know. Thank you!

@de-sh
Copy link
Contributor

de-sh commented May 8, 2024

@ting-ms as mentioned by @swanandx we are low on bandwidth and can't promise when the PRs will be reviewed. I will try my best to get in some time to review your changes by the weekend.

@ting-ms
Copy link
Author

ting-ms commented May 9, 2024

@de-sh Thank you for the update.

@ting-ms
Copy link
Author

ting-ms commented May 17, 2024

Hi @de-sh, I apologize for asking again, but my team is waiting on this feature. Could you provide an estimated time for when the PR will be reviewed and merged? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants