Cleanup: remove server partial move of self in run
#112
Comments
kriswuollett
added a commit
to kriswuollett/registry
that referenced
this issue
May 12, 2023
The impetus behind the change is to support adding monitoring endpoints with an optional additional TCP listener. While refactoring the server it was discovered that the run method moves the Server self, and so fixed bytecodealliance#112 to also ensure that the API endpoint was running before tests could discover the listener's locally bound port. In addition a common cancellation token is added to the server to propagate shutdown to both the core service as well as the API server endpoint. It can be later used to support additional services later such as a monitoring endpoint(s).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It may make more sense to split
runintostartandjoinand mergebindintostartin order to have a clean way to give locally bound ports to tests from astartmethod which also helps guarantee in a way that the web server has started serving on the bound port with a listener before tests hit it.The text was updated successfully, but these errors were encountered: