Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint config only affects editor and not dev or prod environments #3

Open
thisismydesign opened this issue Jul 27, 2020 · 4 comments

Comments

@thisismydesign
Copy link
Member Author

After enabling EXTEND_ESLINT=true the cache needs to be cleared: facebook/create-react-app#9154 (comment)

@thisismydesign
Copy link
Member Author

Check if enabling this overrides the whole config or they are merged. Check which plugins, extensions we should or shouldn't enable.

@thisismydesign
Copy link
Member Author

Extending react-app does include rules from their config. However, for example, eslint-plugin-react show up as warnings instead of errors. Therefore it makes sense to override desired their setup (e.g. extend plugin:react/recommended explicitly).

@thisismydesign
Copy link
Member Author

See fix for typescript: c-hive/cra-typescript-boilerplate@af7c07b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant