chore: reflect webstore upload failure in grunt task #2058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR attempts to fix c301/grunt-webstore-upload#18 in our repository by using the
onError
callback defined here. Sometimes the web release fails because it's in pending review status; our ADO task still succeeds because the status is not reported back to grunt.Tested locally by running:
accessibility-insights-web\drop\extension\dev> npx grunt publish --app-insights-instrumentation-key=test --extension-version=0.0.0 --webstore-app-id=test --webstore-client-id=test --webstore ore-refresh-token=test --force
which ends in:
which differs from the same scenario run against master:
We want the fatal error so that we can more easily check whether the web release has failed.
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). Check workflow guide at:<rootDir>/docs/workflow.md