Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reflect webstore upload failure in grunt task #2058

Merged
merged 2 commits into from
Jan 28, 2020
Merged

chore: reflect webstore upload failure in grunt task #2058

merged 2 commits into from
Jan 28, 2020

Conversation

karanbirsingh
Copy link
Contributor

Description of changes

This PR attempts to fix c301/grunt-webstore-upload#18 in our repository by using the onError callback defined here. Sometimes the web release fails because it's in pending review status; our ADO task still succeeds because the status is not reported back to grunt.

Tested locally by running:
accessibility-insights-web\drop\extension\dev> npx grunt publish --app-insights-instrumentation-key=test --extension-version=0.0.0 --webstore-app-id=test --webstore-client-id=test --webstore ore-refresh-token=test --force

which ends in:

>> Error while uploading:  Error on uploading (open) with message "Invalid Credentials". Raw response: {"error":{"errors":[{"domain":"global","reason":"authError","message":"Invalid Credentials"...<truncated>

Fatal error: Error on uploading (open) with message "Invalid Credentials"...<truncated> 

which differs from the same scenario run against master:

>> Error while uploading:  Error on uploading (open) with message "Invalid Credentials". Raw response: {"error":{"errors":[{"domain":"global","reason":"authError","message":"Invalid Credentials"...<truncated>

Done, but with warnings.

We want the fatal error so that we can more easily check whether the web release has failed.

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). Check workflow guide at: <rootDir>/docs/workflow.md
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@karanbirsingh karanbirsingh requested a review from a team as a code owner January 28, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to publish should fail the task
2 participants