Issue with gene-panel-data/fetch API When molecularProfileIds is Empty

[jonkiky]

Issue with gene-panel-data/fetch API When molecularProfileIds is Empty

I am facing an issue when using the API gene-panel-data/fetch with an empty molecularProfileIds array as the request payload.

Working Example

The following request works correctly:

curl -X POST https://www.cbioportal.org/api/gene-panel-data/fetch \
-H "Content-Type: application/json" \
-d '{
  "molecularProfileIds": [
    "msk_chord_2024_cna",
    "msk_chord_2024_mutations",
    "msk_chord_2024_structural_variants"
  ]
}'

Problematic Request

When we change the request payload to have an empty molecularProfileIds array:

curl -X POST https://www.cbioportal.org/api/gene-panel-data/fetch \
-H "Content-Type: application/json" \
-d '{"molecularProfileIds": []}'

The API responds with an error:

{
  "message": "interceptedGenePanelDataMultipleStudyFilter size must be between 1 and 10000000"
}

Question

Why does interceptedGenePanelDataMultipleStudyFilter require a size between 1 and 10,000,000?

Context

We set up an empty cBioPortal instance, loading only study metadata and clinical data, without any gene panel data (as we don't have it available currently).

After setting this up, when accessing the study view page, it shows an error page.

Investigation

Upon further investigation, the error originates from the following file in the cBioPortal codebase:

File Path: GenePanelDataController.java

Relevant Code (Line 87):

if (CollectionUtils.isEmpty(interceptedGenePanelDataMultipleStudyFilter.getMolecularProfileIds())) {
    // Error occurs here
}

When the payload's molecularProfileIds is empty, getMolecularProfileIds() returns null. Since the program expects a collection or list, this causes an error.

[jonkiky]

I created PR for this fix. Please help me to review it. Thanks

[Aiosa]

I have the same issue and I have similar bugfix locally.

[arishta]

@jonkiky This issue seems to be a duplicate of this one:
#11161