Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build system not working as expected(?) - missing options.js file in output #258

Open
alexanderankin opened this issue Sep 24, 2023 · 0 comments

Comments

@alexanderankin
Copy link

Hi Callum, thanks for a great plugin - I tried building from source and found that the options.js file wasn't being generated anymore.

other things i found were that in order not to perturb the pnpm lockfile, you have to run npx pnpm@7 --frozen-lockfile i - perhaps someone with more pnpm experience than me would be able to be confident in a lockfile upgrade to the latest lockfile version. unfortunately, I wasn't able to figure out how to run the deno task commands using the lockfile in the repo (deno insisted on upgrading from lockfile version 2 to 3) - but this would have been one of the things i was trying to check.

the main issue I am seeing is that the options.html clearly suggests the presence of the options.js file, presumably being compiled from options.ts - but it is not being generated.

steps to reproduce:

git clone $url
cd json-formatter
npx pnpm@7 --frozen-lockfile i
deno task build
find dist/options

expected output:

dist/options
dist/options/options.html
dist/options/options.js

actual output:

dist/options
dist/options/options.html

I'm not sure if im missing something or this is an actual bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant