Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error for test definition "expired_access_token" #147

Closed
bigludo7 opened this issue Sep 20, 2024 · 2 comments · Fixed by #148
Closed

Error for test definition "expired_access_token" #147

bigludo7 opened this issue Sep 20, 2024 · 2 comments · Fixed by #148

Comments

@bigludo7
Copy link
Collaborator

bigludo7 commented Sep 20, 2024

Problem description
We have probably an issue for @NumberVerification_phone_number_share202_expired_access_token

Accordingly to the guideline and consistently with other API in v1.0 as sim swap, location verification, otp, it should be error code UNAUTHENTICATED and not AUTHENTICATION_REQUIRED as describe in both feature files.

Expected behavior
Fix both feature files.

Alternative solution

Additional context
cc @trehman-gsma as it has impact on the certification process.
@fernandopradocabrillo and @AxelNennker to get your feedback

@fernandopradocabrillo
Copy link
Collaborator

Hi @bigludo7
Yes, I agree, this is something I had in mind when reviewing the test definitions PR but due to time constrains I kind of forgot to track.. thanks for bringing it up.

I also think it should be UNAUTHENTICATED for consistency and there should be a more clear guideline on when to use each of the errors.

@bigludo7
Copy link
Collaborator Author

Thanks @fernandopradocabrillo
Do we craft a r1.3?
Adding @hdamker to get his feedback -This is not strictly a bug but more a inconsistency that have impact on the certification process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants