No Snapshot Docker images are built for enterprise versions

[yanavasileva]

Acceptance Criteria (Required on creation)

In the EE Main pipeline,

• Trigger Docker EE GHA - must build and test patch snapshot for maintenance branches
• Trigger Docker CE GHA must be skipped (not executed) for maintenance branches as we don't build CE for patches

Hints

• Trigger Docker EE GHA stages run with the minor release version since 7.17 (when was introduced)
• Trigger Docker CE GHA stages are triggered on daily basis at the moment but we don't build CE snapshots for maintenance branches
  • They push minor versions to the dockerhub (in other words overwrite for example 7.19.0 tag every time the stage run)

Links

Breakdown

Pull Requests

Beta Give feedback

1. fix(ci): trigger docker CE build only on the master branch #3578
   +0
   
2. https://github.com/camunda/camunda-bpm-platform-maintenance/pull/1040
3. https://github.com/camunda/camunda-bpm-platform-maintenance/pull/1041
4. https://github.com/camunda/camunda-bpm-platform-maintenance/pull/1042
5. https://github.com/camunda/camunda-bpm-platform-ee/pull/836
6. https://github.com/camunda/camunda-bpm-platform-ee-maintenance/pull/428
7. fix(ci): trigger maintenance snapshot version docker-camunda-bpm-platform#275
   +0
   
8. fix(ci): trigger maintenance snapshot version docker-camunda-bpm-platform#274
   +0
   
9. https://github.com/camunda/camunda-bpm-platform-ee-maintenance/pull/436
10. fix(ci): trigger maintenance snapshot version docker-camunda-bpm-platform#276
    +0
    
11. https://github.com/camunda/camunda-bpm-platform-ee-maintenance/pull/435
12. fix(ci): trigger maintenance snapshot version docker-camunda-bpm-platform#277
    +0
    

Dev2QA handover

• Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment

[yanavasileva]

Trigger Docker CE GHA stage, decisions:

• Add isDevelopmentVersion check to 7.20 and 7.19. The latter is added for test purposes, validating the check is working on maintenance branches. Once 7.20 is maintenance, the check will prevent triggering the stage and we don't need explicitly remove the stage during the minor release.
• Remove the stage from 7.18 and 7.17 as it's obsolete either way

Assigning @tasso94 for a review, please merge the changes after the review.

[yanavasileva]

WIP, Trigger Docker EE GHA stage:

• The VERSION and SNAPSHOT are hardcoded in the Dockerfile, we cannot change them there as it publicly available repo and community are using the file to build docker images on their own
• Tested that if we adjust those to arguments, the build and test of EE SNAPSHOT is working
  • https://github.com/camunda/docker-camunda-bpm-platform/actions/runs/5533935388
• Idea will be to pass those args from outside
  • Can we pass them from the daily pipeline? TBD, I don't see an option via camundaGitHubWorkflowDispatch
    • if you use in a standard way (example), creating a separate pipeline itself, you can pass inputs param for this.
• Do we want to upload EE SNAPSHOT images? - No

[yanavasileva]

Status quo:
The VERSION and SNAPSHOT are hardcoded in the Dockerfile. Therefore, in maintenance the build and test GHA is executed against 7.XX.0-ee. We cannot just adjust the Dockerfile as it publicly available repo and community are using the file to build docker images on their own.
For triggering the GHA the camundaGitHubWorkflowDispatch global function is used but not as out of the box (why not? - link)

Breakdown, handover of Trigger Docker EE GHA stage:

• SNAPSHOT and VERSION arguments must be past from the Jenkins pipeline: to reduce maintenance efforts and avoid manual adjustments during minor releases. Also version can be fetched from the maven pom (7.19.5) in the camunda-bpm-platform-ee* repository, as in the docker repository is defined only the minor version (7.19.0)
  • version can be fetch via cambpmUtils.getMavenProjectVersion() or pom = readMavenPom file: 'pom.xml'
  • the arguments must be passed as INPUTS parameter (link) via the environment variables in the stage as we don't use out of the box camundaGitHubWorkflowDispatch global function
    • pros - minimal adjustments if this is possible
    • cons - not sure if it is possible to pass a list as environment variable
    • an alternative will be to extract the logic to a separate pipeline and use the camundaGitHubWorkflowDispatch global function out of the box by triggering it from the Daily pipeline and passing the project version as parameter. Example of usage: link
      • pros - straightforward usage without workarounds and we can make the daily EE pipeline to reflect whether the downstream pipeline fails
      • cons - yet another pipeline
• build-and-test-ee.yml must be adjusted to accept SNAPSHOT and VERSION as inputs,
  • example - https://github.com/camunda/docker-camunda-bpm-platform/pull/274/files#diff-f68d93697039df6d1c66a5abde4cd4784234bc2e758f55f7bc17d71bf822b8aa
• pipeline.sh must be adjusted to pass the SNAPSHOT and VERSION as build arguments;
  • example - https://github.com/camunda/docker-camunda-bpm-platform/pull/274/files#diff-557ab0602ac6faca876d8eba540c6a4f692d6aafbe2e0ccf14bfdbc1f3a534eb
• changes must be applied and tested on 7.20 - 7.17
  • if default values are left in the pipeline.sh, 7.20 community CI might be possible to stay unchanged

[tasso94]

Tested scenarios:

• next CI triggered via code change in docker-camunda-bpm-platform
  • fix(ci): trigger maintenance snapshot version docker-camunda-bpm-platform#275
• 7.19 CI triggered via code change in docker-camunda-bpm-platform
  • fix(ci): trigger maintenance snapshot version  docker-camunda-bpm-platform#274
• master CI triggered via code change in camunda-bpm-platform
  • [test] trigger docker image build #3590
• 7.19 CI triggered via code change in camunda-bpm-platform-maintenance
  • https://github.com/camunda/camunda-bpm-platform-maintenance/pull/1046
• master CI triggered via code change in camunda-bpm-platform-ee
  • https://github.com/camunda/camunda-bpm-platform-ee/pull/836
• 7.19 CI triggered via cide change in camunda-bpm-platform-ee-maintenance
  • https://github.com/camunda/camunda-bpm-platform-ee-maintenance/pull/428

[tasso94]

@psavidis, I'll backport to 7.17 once the other PRs are approved.