-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be able to define collapsed by default groups in an element template #3807
Comments
@nikku FYI. Please let me know if I can update the ticket with additional information. Thank you! |
This sounds reasonable, and gives template authors much more freedom to decide which parts of an element template are "initially relevant". This is something we as framework authors cannot and do not want to know. @marstamm Do you recall where we implement the "initially all open" behavior? I'd imagine this could be a fairly straight forward thing to contribute, depending on how we built "always open". |
The default state is defined by a toggle in the Group configuration Currently, it is always |
However, with the way persistence is implemented, the collapsed state of the group is shared across different templates. So if multiple templates have a If we want to change this, we would need to add the template-id to the element template group id |
I think we want to keep this. It is a good feature. Otherwise there is no way to semantically group UI sections across templates. |
@igpetrov Happy to take a contribution to implement Thanks @marstamm for investigating. |
I agree. If you don't want shared state for your template, you can always namespace the group-id in your template to decouple it. |
Thanks a lot @nikku @marstamm! Maybe @bastiankoerber can jump in and also share own thoughts on behalf of the Customers? |
@igpetrov from a framework perspective this is absolut fine, we (as consumer) can then decide which behaviour |
@marstamm Let's tackle documentation as a follow up / part of this issue. |
Created a Draft PR for the docs to be merged after integration: camunda/camunda-docs#2706 |
Fixed upstream via bpmn-io/bpmn-js-element-templates#18 and camunda/element-templates-json-schema#114. |
- [email protected] - [email protected] - [email protected] closes #3876, closes #3510, closes #3807
- [email protected] - [email protected] - [email protected] closes #3876, closes #3510, closes #3807
Problem you would like to solve
Consider any connectors element template, i.e. HTTP REST.
All properties are structured within Groups. All groups are expanded by default. Requesting to add a flag to the
group
element that would indicate that a specific group is collapsed by default.Proposed solution
The following construct should make My Collapsed Group collapsed by default:
Alternatives considered
Since our use-case is epic-related, we could dedicate one specific group for the task definition type property and hardcode it being collapsed by default but I would not recommend taking this route.
Additional context
Via discussion: https://camunda.slack.com/archives/CKGH9LR40/p1693222832075709?thread_ts=1692785474.018059&cid=CKGH9LR40.
This FR is related to the epic, and is a feature gap related to the epic. See related explanation.
The text was updated successfully, but these errors were encountered: