You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed while working on a fork of sandpaper that the CI is producing quite a lot of caches on the GitHub Action runners. Upon further inspection, I think this is due because there are 2 caching steps happening in the R-CMD-check and test-coverage actions:
The problem is that setup-r-dependencies does its own caching by default.
I think they're meant to cache pretty much the same thing (R dependencies of sandpaper), though I'm not sure why the renv caches are typically bigger. In any case I think you only need one of them and having both can eat up quite a lot of caching storage space (might want to check this for the Carpentries organisation).
I'd suggest removing the Restore {renv} cache step (and the dependent Prime {renv} Cache) and let setup-r-dependencies handle the caching. That would also reduce the amount of code to maintain for the sandpaper` devs 😉
Happy to create a PR for this!
The text was updated successfully, but these errors were encountered:
milanmlft
added a commit
to LearnToDiscover/sandpaper
that referenced
this issue
Jun 4, 2024
* Avoid duplicate caching
`r-lib/actions/setup-r-dependencies` already takes care of caching
See also carpentries#591
* Further simplify the `R-CMD-check` action
* Upgrade `actions/checkout` to `v4`
Hi sandpaper devs!
I noticed while working on a fork of
sandpaper
that the CI is producing quite a lot of caches on the GitHub Action runners. Upon further inspection, I think this is due because there are 2 caching steps happening in theR-CMD-check
andtest-coverage
actions:"Restore {renv} cache"
step"Setup dependencies"
step which callssetup-r-dependencies
fromr-lib
The problem is that
setup-r-dependencies
does its own caching by default.I think they're meant to cache pretty much the same thing (R dependencies of
sandpaper
), though I'm not sure why therenv
caches are typically bigger. In any case I think you only need one of them and having both can eat up quite a lot of caching storage space (might want to check this for the Carpentries organisation).I'd suggest removing the
Restore {renv} cache
step (and the dependentPrime {renv} Cache
) and letsetup-r-dependencies handle the caching. That would also reduce the amount of code to maintain for the
sandpaper` devs 😉Happy to create a PR for this!
The text was updated successfully, but these errors were encountered: