From a1a1c66863aa43202d83646ef5b258c6d2e0788a Mon Sep 17 00:00:00 2001
From: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
Date: Wed, 5 Jan 2022 17:32:27 +0530
Subject: [PATCH] Use memoization to reduce redundant api calls

---
 pkg/kapp/resources/resource_types.go | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/pkg/kapp/resources/resource_types.go b/pkg/kapp/resources/resource_types.go
index 8ae1017e5..faf421e29 100644
--- a/pkg/kapp/resources/resource_types.go
+++ b/pkg/kapp/resources/resource_types.go
@@ -46,6 +46,10 @@ func NewResourceTypesImpl(coreClient kubernetes.Interface, opts ResourceTypesImp
 }
 
 func (g *ResourceTypesImpl) All() ([]ResourceType, error) {
+	return g.memoizedAll()
+}
+
+func (g *ResourceTypesImpl) all() ([]ResourceType, error) {
 	serverResources, err := g.serverResources()
 	if err != nil {
 		return nil, err
@@ -141,7 +145,7 @@ func (g *ResourceTypesImpl) memoizedAll() ([]ResourceType, error) {
 	g.memoizedResTypesLock.Lock()
 	defer g.memoizedResTypesLock.Unlock()
 
-	resTypes, err := g.All()
+	resTypes, err := g.all()
 	if err != nil {
 		return nil, err
 	}