Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make asset checks run during integration tests #3928

Open
1 task
zaneselvans opened this issue Oct 23, 2024 · 0 comments
Open
1 task

Make asset checks run during integration tests #3928

zaneselvans opened this issue Oct 23, 2024 · 0 comments
Labels
dagster Issues related to our use of the Dagster orchestrator data-validation Issues related to checking whether data meets our quality expectations. testing Writing tests, creating test data, automating testing, etc.

Comments

@zaneselvans
Copy link
Member

Overview

Asset check failures do not appear to get run or be treated as blocking when run as part of the integration tests.

I swear @jdangerx already tackled this in #3687 but it seems to be back from the dead?

I verified this by running the VCE RARE subset of the DAG using the fast_etl job in the Dagster UI (getting a failure) while the integration tests in the merge-queue requirements / local integration tests have been passing.

Success Criteria

  • The fast ETL in the integration tests fails when an asset check fails.

Tasks
Beta Give feedback
@zaneselvans zaneselvans added testing Writing tests, creating test data, automating testing, etc. dagster Issues related to our use of the Dagster orchestrator data-validation Issues related to checking whether data meets our quality expectations. labels Oct 23, 2024
@zaneselvans zaneselvans changed the title Make asset checks run during integration checks Make asset checks run during integration tests Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dagster Issues related to our use of the Dagster orchestrator data-validation Issues related to checking whether data meets our quality expectations. testing Writing tests, creating test data, automating testing, etc.
Projects
Catalyst Megaproject
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zaneselvans