You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On #196@CodyCBakerPhD did most of the hard work of removing the spikextractors as a dependency and pushed it as an optional work flow.
What is left is to eliminate this completely. In the toy example spike-extractor is used to generate a set of frames in which the spikes occur to transform them to roi (that is, not the spikes times but the actual frames, given a sampling frequency, in which the spikes occurred). We should be able to reproduce this functionality here and eliminate the dependency for good.
So, where is this in the code, the actual functions from spikeextractors are here:
Note that the the recording extractor (rec in the code) is only used to get the sampling frequency and the number of frames which is not really necessary. I will re-structure this in a small PR to make this obvious. The only difficult thing to remove is the production of the spike trains in line 144:
On #196 @CodyCBakerPhD did most of the hard work of removing the spikextractors as a dependency and pushed it as an optional work flow.
What is left is to eliminate this completely. In the toy example
spike-extractor
is used to generate a set of frames in which the spikes occur to transform them to roi (that is, not the spikes times but the actual frames, given a sampling frequency, in which the spikes occurred). We should be able to reproduce this functionality here and eliminate the dependency for good.So, where is this in the code, the actual functions from spikeextractors are here:
roiextractors/src/roiextractors/example_datasets/toy_example.py
Lines 126 to 131 in b71f17d
A recording and a spikextractor. They only use is here:
roiextractors/src/roiextractors/example_datasets/toy_example.py
Lines 140 to 151 in b71f17d
Note that the the recording extractor (rec in the code) is only used to get the sampling frequency and the number of frames which is not really necessary. I will re-structure this in a small PR to make this obvious. The only difficult thing to remove is the production of the spike trains in line 144:
roiextractors/src/roiextractors/example_datasets/toy_example.py
Line 144 in b71f17d
So, a function that produces frames in which spikes occur in some reasonable fashion should suffice for this small toy example.
The text was updated successfully, but these errors were encountered: