-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss Miniscope input folder expected structure #356
Comments
The reason for passing the parent folder was because the example that we have on gin consists of multiple subfolders with avi files that belong to the same recording session. On the other hand if we provided one of the subfolders like @h-mayorquin are you suggesting this is the case with your example? FYI @alessandratrapani, I believe you also have Miniscope data in your current conversion. |
Yes, that does not work for the data of Cai.
Yeah, I disagree with this. I think that it would be better if the extractor was more specific. The user can add two interfaces for each collection of raw data if so they desire. Otherwise, we don't have the option of not adding some of the data. |
In particular, these extractors should be scoped per-session, but it looks like this one takes a folder path with multiple sessions (dates), so it probably needs to be changed. |
What do you mean? You mean that it should load all the data corresponding to that session? Interfaces in neuroconv should not work like that and an extractor making that assumption would make things difficult. Is that a decision that you guys made or are you talking about some specific knowledge about this format? |
@pauladkisson the example from the Tye lab that we have on gin is still a single session; just saved to multiple folders. apologise if that wasn't clear. |
My bad, for some reason |
Ok, I managed to found the specification in the Miniscope page and surprise... it does not correspond to either the structure of the gin data (coming from the Tye Lab) or my current project: http://miniscope.org/index.php/Data_Acquisition_Software So what gives? I will ask the experimenter in our next meeting if he did change the file structure to try to get to the bottom of this. |
OK, there is also a versioning issue. I will push a fix. |
I discussed this with @weiglszonja this morning. There are other problems with the current implementation:
Here is a json miniscope metadata from the example data: {
"compression": "FFV1",
"deviceDirectory": "C:/mData/2021_10_07/C6-J588_Disc5/15_06_28/Miniscope",
"deviceID": 2,
"deviceName": "Miniscope",
"deviceType": "Miniscope_V3",
"frameRate": "15FPS",
"framesPerFile": 1000,
"gain": "High",
"led0": 47
} But the structure is that of the version 4 according to the extension: So, Szonja and I agree that is probably better to create a new extractor takes as an input the timestamp folder and is specific for v4. We can then think on how to integrate these two modalities in the future. |
Also relevant: |
Here, yet another folder structure reported: |
Currently in the gin example file we have this structure:
And in the test we pass to the extractor the folder that is at the top level:
roiextractors/tests/test_miniscopeimagingextractor.py
Lines 18 to 19 in 11c759c
However, this structure with a parent folder that contains multiple (and only) datasets of miniscope is not available in my current working project. There I have:
It appears to me that the natural thing to pass to the extractor is the folder where the videos are. Why are we passing the parent folder? I tried to look for documentation of where this output is coming from without luck here:
https://github.com/Aharoni-Lab/Miniscope-DAQ-QT-Software
@weiglszonja @pauladkisson do you know? how do you think about this?
The text was updated successfully, but these errors were encountered: