Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] FuzzyMap.IKey is package private #505

Open
shaburov opened this issue Oct 18, 2020 · 4 comments
Open

[BUG] FuzzyMap.IKey is package private #505

shaburov opened this issue Oct 18, 2020 · 4 comments

Comments

@shaburov
Copy link

jcommander-1.78

image

@bluecontainer
Copy link

I spent some time integrating jcommander and unit testing it. When I went to build the application package, I also came across this error. Since it is a simple fix, can I submit a PR and have this included in the 1.84 release?

@mkarg
Copy link
Collaborator

mkarg commented Nov 10, 2023

It would be nice if someone could post a complete and comprehensible problem description. FuzzyMap is not intended to be part of the public API. We should replace it in the API by etc. Object.

@bluecontainer
Copy link

bluecontainer commented Nov 14, 2023

While IKey may not be intended to be part of the public API, it is currently made public in the method on class JCommander:

public Map<IKey, ParameterDescription> getDescriptions() { return descriptions; }
I found it useful to be able interrogate the parameter descriptions using this method.

While the best solution might be to change the interface on JCommander so as not to expose IKey, the quick option is to make IKey public

public class FuzzyMap { public interface IKey { String getName(); } . .

Since this method is broken anyway, so no one could be using it, perhaps there is no harm in changing the interface to not expose IKey.

@mkarg
Copy link
Collaborator

mkarg commented Nov 16, 2023

Since this method is broken anyway, so no one could be using it, perhaps there is no harm in changing the interface to not expose IKey.

We should go with that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants