Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary merkle proofs accepting multiple total values as correct #259

Open
rach-id opened this issue Nov 9, 2023 · 0 comments
Open

Binary merkle proofs accepting multiple total values as correct #259

rach-id opened this issue Nov 9, 2023 · 0 comments

Comments

@rach-id
Copy link
Member

rach-id commented Nov 9, 2023

Assume you have a merkle tree of 5 leaves. When creating the proof, if you set the number of leaves in [5, 8], the proof going to pass even if {6, 7, 8} are invalid values because with those numbers of leaves, the verifier will behave the same.

Verified with the implementation of tendermint and it also has the same behavior.

Thus, we have thought about this edge case and it doesn't seem to represent any issue. If any arises, we can document them in this issue.

Originally posted by @sweexordious in #253 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant