Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock dates don't account for leap years #35

Open
rootulp opened this issue Sep 9, 2024 · 0 comments
Open

Unlock dates don't account for leap years #35

rootulp opened this issue Sep 9, 2024 · 0 comments

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 9, 2024

Context

#34

Problem

It looks like vesting accounts unlock 365 days after TGE, not 366 days. In other words, they don't account for leap years.

Proposal

  1. Update internal/dates.go to ignore leap years.
  2. Resolve the TODO introduced in fix: year one unlock date #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp