Fixing flakey tests #1883
Closed
Fixing flakey tests #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-toptal
requested review from
hbandura and
37ng
and removed request for
a team
TestEthClient and TestGethClient
Codecov Report
@@ Coverage Diff @@
## master #1883 +/- ##
==========================================
+ Coverage 54.38% 54.44% +0.05%
==========================================
Files 673 674 +1
Lines 88954 88983 +29
==========================================
+ Hits 48382 48448 +66
+ Misses 36925 36875 -50
- Partials 3647 3660 +13
Continue to review full report at Codecov.
|
37ng
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Very nice, it's been a pain that nodes weren't listening : )
Thanks for contributing @andrei-toptal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed flakey tests in
TestEthClientandTestGethClient.Other changes
Semantic of the existing code/tests was not changed.
Tested
Consistently failed before the fix and consistently survive these commands with the fix.
go test -race -count=100 -run ^TestEthClient$ github.com/celo-org/celo-blockchain/ethclientgo test -race -count=100 -run ^TestGethClient$ github.com/celo-org/celo-blockchain/ethclient/gethclientRelated issues
Backwards compatibility
NA