You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In general, we want traces to ignore EVM CALL's made by the client during the course of execution (i.e. when looking up an address in the registry, as happens while making a transfer via the precompile). We can most likely do this by turning Debug mode off (as is currently done in TobinTransfer logic), but doing this in the SharedEVMRunner instead, which is only used for executing calls made by the client and shouldn't be traced.
Additionally as part of the ticket, update the e2e tests:
TestCallTraceTransactionPrecompileTransfer -- the traces should change
add stricter checking to the TestTraceSendCeloViaGoldToken test (and remove associated TODO with this issue)
The text was updated successfully, but these errors were encountered:
In general, we want traces to ignore EVM
CALL
's made by the client during the course of execution (i.e. when looking up an address in the registry, as happens while making a transfer via the precompile). We can most likely do this by turning Debug mode off (as is currently done inTobinTransfer
logic), but doing this in theSharedEVMRunner
instead, which is only used for executing calls made by the client and shouldn't be traced.Additionally as part of the ticket, update the e2e tests:
TestCallTraceTransactionPrecompileTransfer
-- the traces should changeTestTraceSendCeloViaGoldToken
test (and remove associated TODO with this issue)The text was updated successfully, but these errors were encountered: