Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for MentoFeehandlerSeller.t.sol #11173

Open
arthurgousset opened this issue Jul 23, 2024 · 0 comments
Open

Add tests for MentoFeehandlerSeller.t.sol #11173

arthurgousset opened this issue Jul 23, 2024 · 0 comments

Comments

@arthurgousset
Copy link
Contributor

arthurgousset commented Jul 23, 2024 •
edited
Loading

Context from Slack:

related question, I see we don’t have any issue to migrate MentoFeeHandlerSeller, I think this is right because the implementation we currently have is broken by current Mento in mainnet.

There could be an option to fix the MentoFeeHandlerSeller to work on mainnet.

There is no specific mentofeehandlerseller.ts test like we have for uniswapfeehandlerseller.ts.

I think the test doesn’t exist because it is embebed in the FeeHandler test (hard to test without a handler).
but probably wont hurt to have one

Related to:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arthurgousset