Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract away Tunnel logic and return real errors #11266

Open
m-chrzan opened this issue Nov 5, 2024 · 0 comments
Open

Abstract away Tunnel logic and return real errors #11266

m-chrzan opened this issue Nov 5, 2024 · 0 comments

Comments

@m-chrzan
Copy link
Contributor

m-chrzan commented Nov 5, 2024

Expected Behavior

The ReleaseGold unit tests, which use a "mock tunnel" interface for calling the initialize function, should test for the exact expected error messages.

This can be done with recoverErrorString, introduced in #11263.

Additionally, logic common to tunnels should be abstracted away into a separate contract to inherit from.

Current Behavior

MockInitialize reverts with "unsuccessful tunnel call", not the original error message.

Logic is duplicated between the two tunnel contracts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant