Add missing RBAC and update images to latest release #163
+181
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed duplicate entries in the rbd clusterrole Signed-off-by: Madhu Rajanna <[email protected]>
adding the missing rbac for both cephfs and rbd to support all the features we have in cephcsi that is supported in Rook/cephcsi Signed-off-by: Madhu Rajanna <[email protected]>
updating the images to the latest release. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
changed the title
|
/lgtm |
leelavg
approved these changes
Oct 30, 2024
nb-ohad
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes to add the missing RBAC compared to the CSI rbac we have in Rook repository and also it updates the csi image that works with latest version of external-provisioner
Note:- cephfs PVC creation is failing without this fix(with default images).