Implement kill-run button #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
2 tasks
|
@Devansh3712 |
kamoltat
approved these changes
Jul 10, 2023
|
@kamoltat I don't think we should have merged this yet. The button is visible but not functional, and we send requests to a third-party service whenever it's pushed. In addition to being a UX issue it's also a privacy issue. It's deployed live. |
|
@zmc Ahh yes I understand the third-party service & privacy issue. With the live thing, I think one can argue that people/users knows the https://pulpito-ng.ceph.com/ is still like in development although it is technically in production so they won't complain as much as if we were to do something similar in https://pulpito.ceph.com/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #2 which adds a kill run button that will kill all jobs in the current run. It currently uses a mock API endpoint for success alert, needs to be connected to the
teuthology-api