-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using churn gem #20
Comments
Nice! I'll take a look, see how hard it is to pull in. |
Cool idea @bf4 I would be interested in helping out. churn due for a bit of refactoring. Likely just cleaning up the interface to detecting and querying interface for SCMs. I was looking at turbulance and https://github.com/chad/turbulence/blob/master/lib/turbulence/scm/git.rb and https://github.com/chad/turbulence/blob/master/lib/turbulence/calculators/churn.rb and the likely equivalent in the churn project https://github.com/danmayer/churn/blob/master/lib/churn/git_analyzer.rb Seems we could probably hook them up around there. Although if we want multiple SCM support, churn does that in the not very well factored out https://github.com/danmayer/churn/blob/master/lib/churn/churn_calculator.rb#L181 The last big thing I noticed is that turbulence supports perforce, which amazingly enough isn't on the list of SCMs that churn currently supports. I could try to add support for that so moving over would only add features opposed to deprecating anything. @kerrizor let me know your thoughts and we can see if we can work something sane out. |
Before trying to add perforce support or adding any methods to return the data turbulence expects I started refactoring chrun a bit to make it easier to work with the various SCMs supported. You can see the first bit of progress I plan to pull a few more methods out of the calculator and move them into the SCM classes. After a little bit more refactoring, I will try to get perforce support added. |
Consider @danmayer's churn gem. One less thing to maintain :)
The text was updated successfully, but these errors were encountered: