Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

train_valid_split sometime fails. #319

Open
corochann opened this issue Feb 4, 2019 · 0 comments
Open

train_valid_split sometime fails. #319

corochann opened this issue Feb 4, 2019 · 0 comments

Comments

@corochann
Copy link
Member

BaseSplitter's train_valid_split checks assert len(test_inds) == 0.

when i use RandomSplitter, it failed. i guess calculation of

        train_data_size = int(len(dataset) * frac_train)
        valid_data_size = int(len(dataset) * frac_valid)

may sometimes remain rest indices even if frac_train + frac_valid == 1.

we should check other splitter class and add test too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corochann